Implementing EntityKeyValues by KillStr3aK · Pull Request #615 · roflmuffin/CounterStrikeSharp

KillStr3aK · 2024-10-08T05:48:49Z

Mostly based on #440 by @Yarukon

Implemented CEntityKeyValues, can be used like:

CDynamicProp? prop = Utilities.CreateEntityByName<CDynamicProp>("prop_dynamic");

if (prop != null)
{
    CEntityKeyValues keyValues = new CEntityKeyValues();

    keyValues.SetBool("my_bool", true);
    keyValues.SetEHandle("player_handle", player.EntityHandle);
    keyValues.SetVector("vector", new Vector(15.0f, 250.0f, 300.0f));
        
    prop.DispatchSpawn(keyValues);
}

This is also possible:

CDynamicProp? prop = Utilities.CreateEntityByName<CDynamicProp>("prop_dynamic");

if (prop != null)
{
    CEntityKeyValues keyValues = new CEntityKeyValues();

    keyValues["my_bool", KeyValuesType.TYPE_BOOL] = true;
        
    prop.DispatchSpawn(keyValues);
}

Also implemented some of the math related classes minimally, however: we need #613 in order to prevent memory leaks related to them. (changes needed later on if this one gets merged earlier, or I can make the adjustments on this if 613 is merged.)

KillStr3aK · 2024-10-08T05:52:32Z

managed/CounterStrikeSharp.API/Core/ScriptContext.cs

+            if (type == typeof(Color))
+            {
+                var pointer = (IntPtr)GetResult(typeof(IntPtr), ptr);
+                return Marshaling.ColorMarshaler.NativeToManaged(pointer);
+            }


This one should be there since the beginning I believe haha

KillStr3aK · 2024-10-08T05:52:49Z

managed/CounterStrikeSharp.API/Core/ScriptContext.cs

+            if (type == typeof(CEntityHandle))
+            {
+                return new CEntityHandle((uint)GetResult(typeof(uint), ptr));
+            }


I hope this one fits?

KillStr3aK · 2024-10-08T05:53:47Z

src/scripting/natives/natives_entities.cpp

+
+        case counterstrikesharp::TYPE_COLOR:
+        {
+            script_context.SetResult(new Color(keyValues->GetColor(key)));


This one sadly leaks even if #613 is merged, however could be fixed by using the MemAlloc from #613 to release the ptr either in the ScriptContext or in the ColorMarshaler once the values are converted

KillStr3aK · 2024-10-08T05:54:33Z

src/scripting/natives/natives_entities.cpp

+            script_context.SetResult(new Vector(keyValues->GetVector(key)));
+            break;
+        }
+
+        case counterstrikesharp::TYPE_VECTOR2D:
+        {
+            script_context.SetResult(new Vector2D(keyValues->GetVector2D(key)));
+            break;
+        }
+
+        case counterstrikesharp::TYPE_VECTOR4D:
+        {
+            script_context.SetResult(new Vector4D(keyValues->GetVector4D(key)));
+            break;
+        }
+
+        case counterstrikesharp::TYPE_QUATERNION:
+        {
+            script_context.SetResult(new Quaternion(keyValues->GetQuaternion(key)));
+            break;
+        }
+
+        case counterstrikesharp::TYPE_QANGLE:
+        {
+            script_context.SetResult(new QAngle(keyValues->GetQAngle(key)));
+            break;
+        }
+
+        case counterstrikesharp::TYPE_MATRIX3X4:
+        {
+            script_context.SetResult(new matrix3x4_t(keyValues->GetMatrix3x4(key)));


These should not leak with #613 because the wrapper classes will be DisposableMemory and when its no longer used on the managed side these pointers are released

KillStr3aK · 2024-10-08T05:55:01Z

src/scripting/natives/natives_vector.cpp

+Vector2D* Vector2DNew(ScriptContext& script_context)
+{
+    return new Vector2D();
+}
+
+Vector4D* Vector4DNew(ScriptContext& script_context)
+{
+    return new Vector4D();
+}
+
+matrix3x4_t* Matrix3x4New(ScriptContext& script_context)
+{
+    return new matrix3x4_t();
+}
+
+Quaternion* QuaternionNew(ScriptContext& script_context)
+{
+    return new Quaternion();
+}


Same as above!

KillStr3aK · 2024-10-08T08:54:50Z

src/scripting/natives/natives_entities.cpp

+
+CEntityKeyValues* EntityKeyValuesNew(ScriptContext& script_context)
+{
+    return new CEntityKeyValues();


forgot to mention that this one is also will be released with #613

…lues`

…`, `matrix3x4_t`

Prefix · 2025-01-08T12:11:08Z

Would be nice to have this released, otherwise prop_ragdoll bugs with velocity without setting pos before dispatchspawn

oylsister · 2025-01-27T14:13:25Z

I have tested this specific PR on Linux and it's working fine.

P250 · 2025-04-03T21:56:17Z

Any update on this? :)

derkalle4 · 2025-06-15T16:25:17Z

Is there any update on this? :) would love to have it merged if possible.

MarkKuiper-Infra · 2025-07-28T10:55:01Z

Any updates on this PR? Would be great to have this merged.

TomaszPobierski · 2025-09-02T10:38:48Z

Please, give any information about it @KillStr3aK

KillStr3aK · 2025-09-02T10:54:31Z

Any update on this? :)

Is there any update on this? :) would love to have it merged if possible.

Please, give any information about it @KillStr3aK

other than the conflicts with the main branch the pr is ready, and it does not depend on #613 , but it would just bring even more leaks to the table. I did not look for a solution since that as I'm busy these days but the main implementation is here if someone finds a solution for the leak issues faster than I do

oscar-wos · 2025-10-27T17:21:24Z

#1090

roflmuffin · 2025-12-15T06:58:37Z

A variation of this has been merged in #1146 and released in v1.0.351

KillStr3aK commented Oct 8, 2024

View reviewed changes

KillStr3aK marked this pull request as ready for review October 8, 2024 06:02

KillStr3aK requested a review from roflmuffin as a code owner October 8, 2024 06:02

KillStr3aK changed the title ~~[DRAFT] Implementing EntityKeyValues~~ Implementing EntityKeyValues Oct 8, 2024

KillStr3aK commented Oct 8, 2024

View reviewed changes

KillStr3aK mentioned this pull request Oct 8, 2024

[DRAFT] Featuring MemoryManager to resolve issues related to native memory leaking #613

Draft

KillStr3aK added 20 commits October 10, 2024 07:33

feat: CBaseEntity_DispatchSpawn in unmanaged

d9ad31c

feat: entity keyvalues unmanaged implementation

34a4b4b

feat: entity keyvalues managed implementation

787809b

feat: overload DispatchSpawn

4b10307

chore: adjusted codestyle

10768f6

chore: adjusted codestyle and cleanup

ffc0320

feat: inherit from dictionary to use indexing, adjustments

7ed06c4

chore: edit summary

a279da3

fix: reimplement getter/setter natives and fully expose `CEntityKeyVa…

548c76d

…lues`

chore: FIX GETTER REGION

e1225ba

feat: default implementations for Vector2D, Vector4D, `Quaternion…

71de499

…`, `matrix3x4_t`

tweak: adjust changes

62089d2

fix: adjusted natives

4c09221

feat: overload SetVector

321782f

feat: overloaded ToString method

84fe54c

tweak: replaced with CUtlStringToken

1fb3803

fix: Added Color to ScriptContext.GetResult

78e1bf2

fix: these should return a pointer instead

f064354

fix: *GetInt64

c42319c

feat: CEntityKeyValues.HasValue

13fb3af

KillStr3aK added 3 commits October 10, 2024 07:33

feat: properties for accessing values

8b5dc87

tweak: adjusted matrix3x4_t changes

b684fef

fix: changed from CUtlStringToken to uint

7d346df

KillStr3aK force-pushed the feature/entitykeyvalues branch from 293a3a8 to 7d346df Compare October 10, 2024 05:33

KillStr3aK mentioned this pull request Oct 10, 2024

[NeedHelp] Not possible to spawn a decal dynamically? #500

Open

KillStr3aK added 10 commits October 11, 2024 11:22

Merge branch 'main' into feature/entitykeyvalues

d9fcb7e

Merge branch 'main' into feature/entitykeyvalues

6812f62

Merge branch 'main' into feature/entitykeyvalues

817a158

Merge branch 'main' into feature/entitykeyvalues

d81c8f0

Merge branch 'main' into feature/entitykeyvalues

eb52035

Merge branch 'main' into feature/entitykeyvalues

7a83255

Merge branch 'main' into feature/entitykeyvalues

d3209cb

Merge branch 'main' into feature/entitykeyvalues

0697b7c

Merge branch 'main' into feature/entitykeyvalues

e210a27

Merge branch 'main' into feature/entitykeyvalues

b517713

KillStr3aK mentioned this pull request Jan 5, 2025

Make NetworkedVector support Vector and QAngle #728

Merged

Merge branch 'main' into feature/entitykeyvalues

59dffad

KillStr3aK added 2 commits January 16, 2025 19:30

Merge branch 'main' into feature/entitykeyvalues

58f1f4c

Merge branch 'main' into feature/entitykeyvalues

51020e4

Merge branch 'main' into feature/entitykeyvalues

2dda73a

roflmuffin closed this Dec 15, 2025

Uh oh!

Conversation

KillStr3aK commented Oct 8, 2024

Uh oh!

KillStr3aK Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

KillStr3aK Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

KillStr3aK Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KillStr3aK Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

KillStr3aK Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

KillStr3aK Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

Prefix commented Jan 8, 2025

Uh oh!

oylsister commented Jan 27, 2025

Uh oh!

P250 commented Apr 3, 2025

Uh oh!

derkalle4 commented Jun 15, 2025

Uh oh!

MarkKuiper-Infra commented Jul 28, 2025

Uh oh!

TomaszPobierski commented Sep 2, 2025

Uh oh!

KillStr3aK commented Sep 2, 2025

Uh oh!

oscar-wos commented Oct 27, 2025

Uh oh!

roflmuffin commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

KillStr3aK Oct 8, 2024 •

edited

Loading