feat: add symbols support in FindSignature#1052
feat: add symbols support in FindSignature#1052qstage wants to merge 1 commit intoroflmuffin:mainfrom
FindSignature#1052Conversation
| } | ||
|
|
||
| return module->FindSignature(bytesStr); | ||
| return bytesStr[0] == '@' ? module->FindSymbol(bytesStr + 1) : module->FindSignature(bytesStr); |
There was a problem hiding this comment.
Won't this cause issues if the first byte of a signature is 0x40, like it currently is for CGameEventManager_Init on windows?
There was a problem hiding this comment.
Won't this cause issues if the first byte of a signature is 0x40, like it currently is for
CGameEventManager_Initon windows?
CounterStrikeSharp/src/core/memory.cpp
Lines 25 to 34 in 87a5a2f
the bytesStr parameter is a string, not raw bytes
so, for "40 53 ..."(CGameEventManager_Init on windows), bytesStr[0] is the char -> '4', not the byte -> 0x40 (char -> '@')
the '@' prefix check happens at the string level before any hex parsing, so there's no conflict with signatures that have 0x40 as their first byte, imo
No description provided.