feat(vncscreen.tsx): supports a websocket instance as prop which may be pre-authenticated #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
react-vncrequires a WebSocket URL and handles the connection internally. However, many VNC servers require custom authentication flows (cookie-based auth, token-based auth, MessagePack handshakes, etc.) that must be completed before the VNC protocol can begin.This enhancement allows users to:
API Changes
Added a new optional prop
websocketto theVncScreencomponent:urlorwebsocketmust be providedwebsocketis provided, it takes precedence overurlurlcontinues to work unchangedImplementation Details
RFBinitialization to accept either URL string or WebSocket instance (noVNC already supports both)Before submitting the PR, please take the following into consideration
feat:,fix:,chore:,docs:, orrefactor:.mainbranch.