Skip to content

Conversation

@roerohan
Copy link
Owner

Description

Removed the loadingUI, instead exposed the loading state so that the user can configure the loading UI on their own, as discussed in #65.

Also, the extra div wrapping the VNC div was removed.

Resolved issues

Closes #65

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@roerohan roerohan self-assigned this Mar 31, 2025
@roerohan roerohan merged commit 4e204ae into main Mar 31, 2025
3 checks passed
@roerohan roerohan deleted the fix-ui-div branch March 31, 2025 08:05
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra wrapper <div> makes height: 100% not work

2 participants