-
-
Notifications
You must be signed in to change notification settings - Fork 18
Update AI model version to gpt-5 and increase maxDepth to 10 in use cases #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -34,7 +34,7 @@ export class RequestInfoFromTableWithAIUseCaseV6 | |||||
| extends AbstractUseCase<RequestInfoFromTableDSV2, void> | ||||||
| implements IRequestInfoFromTableV2 | ||||||
| { | ||||||
| private readonly maxDepth: number = 5; | ||||||
| private readonly maxDepth: number = 10; | ||||||
|
||||||
| private readonly maxDepth: number = 10; | |
| private readonly maxDepth: number = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doubling maxDepth from 5 to 10 iterations could significantly increase API costs and response times. Each iteration involves an AI model call and potentially multiple database queries through tool execution. Consider the following:
If this change is intentional to handle more complex queries, consider adding monitoring or logging to track how often the increased depth limit is actually needed in production. This would help validate whether the cost/performance tradeoff is justified.