feat: add frontend charts/saved queries feature #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gugu
commented
Jan 22, 2026
gugu
commented
- Add chart.js and ng2-charts dependencies
- Create saved-query models and SavedQueriesService
- Add charts-list component with search and delete functionality
- Add chart-edit component with Monaco SQL editor and chart preview
- Add chart-preview component using Chart.js (bar, line, pie, doughnut, polar area)
- Add chart-delete-dialog component
- Add charts tab to navigation for all connections
- Add routes for /charts/:connection-id, /new, and /:query-id
- Add chart.js and ng2-charts dependencies - Create saved-query models and SavedQueriesService - Add charts-list component with search and delete functionality - Add chart-edit component with Monaco SQL editor and chart preview - Add chart-preview component using Chart.js (bar, line, pie, doughnut, polar area) - Add chart-delete-dialog component - Add charts tab to navigation for all connections - Add routes for /charts/:connection-id, /new, and /:query-id Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
gugu
requested review from
Copilot and
lyubov-voloshko
and removed request for
Copilot
Changed create/edit chart buttons to anchor tags with routerLink for better accessibility and navigation behavior. Moved Charts to be the second navbar item after Tables. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add rxResource to SavedQueriesService for reactive data fetching - Add savedQueries, savedQueriesLoading signals and setActiveConnection/refreshSavedQueries methods - Update ChartsListComponent to consume service signals instead of local state - Fix Monaco editor cursor position issue by using signal that only updates on load - Auto-execute test query when editing existing chart to show preview - Replace all `as any` type assertions in chart test files with proper typed interfaces - Use Partial<ServiceType> for mock services and component testable types Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add Angular Signals as core technology - Update service example to show rxResource pattern - Update component structure to show signal-based state - Update test structure to show proper typing (no `as any`) - Add signals requirement section in important notes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.