-
Notifications
You must be signed in to change notification settings - Fork 12
Set of various fixes #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@skasperski this probably does no longer crash rock-runtime. |
|
9bd9ce8 to
7c9b730
Compare
instead of indexing into the const char * literal
3f59b25 to
374d135
Compare
|
The data actually was freed twice. The right thing to do is to have the rtt-typelib deallocate and free it(as was done before), it does call the destructor. And then i went on a hunt for a leak inside std::strings, first thinking they'd still do copy-on-write(they don't), guessing the deallocation should happen far away. Then wondering why the CNDHandlerConfig's destructor was not destroying its strings(it did), only to find that the temporary string used to push the data into its parent vector was not destroyed. This leaked one copy of the contents of all containers(typelib speak for strings and vectors) that reside inside another container, at each stage where a container is built. |
Take 2: fixed the memory leak fix crash, dropped the build system stuff for now.
The build system stuff needs changes elsewhere(base/cmake currently breaking knowledge_reasoning/gqr) to work right.