chore: use the cache flag for the data_service inherited attribute (on top of #542)
#541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonasiv
reviewed
Dec 16, 2025
Comment on lines
+58
to
+59
| data_services_clear | ||
| dynamic_services_clear |
Contributor
There was a problem hiding this comment.
couldnt find references to these methods, where are they?
Member
Author
There was a problem hiding this comment.
Defined by inherited_attributes
doudou
force-pushed
the
optimizations
branch
from
5fc64bc to
280c676
Compare
doudou
changed the title
cache flag for the data_service inherited attribute
doudou
changed the title
cache flag for the data_service inherited attributecache flag for the data_service inherited attribute (on top of #542)
doudou
force-pushed
the
optimizations
branch
2 times, most recently
from
fe4eea6 to
56e0054
Compare
doudou
force-pushed
the
micro-opt
branch
2 times, most recently
from
ccf840a to
9dd7c0d
Compare
doudou
force-pushed
the
optimizations
branch
from
56e0054 to
5a52963
Compare
They are actual components, not deployments, and are needed for dataflow analysis
I did not change the !( ... <= ... ) into ( ... > ... ) as even if Ruby somehow pretends the order is total, it really is not. That is, I would expect A < B and A > B to both return false (or even nil) for unrelated classes.
This is inconsequential for live systems, but makes general performance debugging easier.
Doing new-then-add creates a TemplatePlan first, which is then copied to the real plan. The copy operation is relatively cheap, but unnecessary
…rvice? when applicable
doudou
force-pushed
the
optimizations
branch
from
5a52963 to
b8a8479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
On top of #542