fix: forward explicitly set services #356
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doudou
force-pushed
the
transition-to-runkit
branch
from
75f8fa1 to
42d7f4c
Compare
doudou
force-pushed
the
forward-explicitly-set-services
branch
from
72415fa to
bbfbd92
Compare
The placeholder models (of which the most obvious instance is the profile tag) were handled as normal component models by DependencyInjection. This led to their selection to be reduced to component models as well, which fails if there are ambiguities and one want to select a particular service, that is some_tag => component_m.my_srv Rewrite the selection logic to use the placeholder-friendly API (each_required_model and fullfills?)
doudou
force-pushed
the
forward-explicitly-set-services
branch
from
bbfbd92 to
b214536
Compare
Member
|
Ping @wvmcastro |
wvmcastro
reviewed
Jun 2, 2025
Comment on lines
+233
to
+234
| task_m.provides srv_m, as: "srv1" | ||
| task_m.provides srv_m, as: "srv2" |
There was a problem hiding this comment.
how providing the same service twice is relevant for this test?
Member
There was a problem hiding this comment.
It makes sure that the system does not fall back on the implicit service selection code path (since that code path would fail). The caller must explicitly select a service.
wvmcastro
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.