Add Factory Droid agent support #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Inspired by your blog post I just tried if I can add support without knowing Go :) |
Add support for Factory's Droid CLI (https://factory.ai) as a code review agent. - Add DroidAgent implementation using `droid exec` for headless execution - Support --auto low (review mode) and --auto medium (agentic/refine mode) - Support --reasoning-effort for thorough/fast modes - Add comprehensive tests for all functionality - Update README with Droid in supported agents table Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Prevents prompts starting with "-" from being parsed as flags by the droid CLI. For example, a prompt like "-o /tmp/x" would otherwise be interpreted as command-line flags. Added unit test to verify prompts with leading dashes are passed as data. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Avoids piping remote code to sh in documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Droid CLI doesn't support -C for setting working directory. The working directory is already set via cmd.Dir in Review(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Droid CLI uses -o for --output-format, not output file. Changed to capture stdout directly like the real droid CLI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
Thanks. This didn't work for me out of the box but I am fixing it now |
wesm
force-pushed
the
add-factory-droid-support
branch
from
976365d to
9b794fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Factory's Droid CLI as a code review agent, enabling roborev users who use Droid to get automatic code reviews.
Changes
internal/agent/droid.go- DroidAgent implementation usingdroid execfor headless executioninternal/agent/droid_test.go- Comprehensive tests (9 test cases)internal/agent/agent.go- Add "droid" to fallback orderREADME.md- Add Droid to supported agents tableImplementation Details
droid execwith--auto lowfor read-only review mode--auto mediumfor agentic mode (refine)--reasoning-effortfor thorough/fast reasoning levelsTest Plan
go build ./...passesgo test ./...passes (all 50 agent tests, including 9 new droid tests)