Windows support: PowerShell installer, codex stdin fix, ARM64 builds #77
+534
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add scripts/install.ps1 for native Windows installation - Update README with Windows installation instructions - Follows uv-style installation: powershell -ExecutionPolicy ByPass -c "irm URL | iex" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
The install script works, but Windows support is currently broken (the daemon/tui work, but the reviews do not execute properly) and will take some work to fix. |
Windows has a ~32KB command line argument limit, which large diffs easily exceed. This caused codex to receive truncated or empty prompts, resulting in "I don't see the commit content" errors. Changed the codex agent to pipe the prompt via stdin (using "-" as the prompt argument), consistent with how claude and gemini agents already work. This fix benefits all platforms. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add Windows ARM64 to release build matrix - Fix PowerShell 5.x vs 6+ compatibility (-UseBasicParsing removed in PS6+) - Error clearly on 32-bit Windows instead of silently failing - Add SHA256 checksum verification for downloaded archives - Use correct checksums filename (SHA256SUMS) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move "-" stdin marker after all flags (including -c) to ensure proper flag parsing - Always add --full-auto in non-agentic mode since stdin is always a pipe (removed stale os.Stdin TTY check) - Remove unused isatty dependency - Add test verifying prompt is piped via stdin Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Make checksum verification fail-closed by default (abort on errors) - Add ROBOREV_SKIP_CHECKSUM env var for explicit bypass - Fix regex matching bug: use [regex]::Escape() and match at end of line - Error on multiple checksum matches instead of silently using first Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wesm
changed the title
- Make ConfigWatcher not restart-safe: Start() returns error after Stop() has been called, with clear documentation to create new instance - Add ReloadCounter for sub-second reload detection (monotonic uint64) - Change ConfigReloadedAt format to RFC3339Nano for better precision - Add TestConfigWatcher_AtomicSaveViaRename for editor-style saves - Add TestConfigWatcher_StartAfterStopErrors for restart behavior - Add TestConfigWatcher_ReloadCounter for counter increment verification - Update TUI to use ConfigReloadCounter instead of timestamp comparison - Update TUI tests to use counter-based reload detection Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- config_watcher.go: Set watcher to nil after close in error path to prevent potential double-close if Stop() is called later - main_test.go: Update header comment to reflect ROBOREV_DATA_DIR usage instead of HOME - update.go: Add explicit check for Unix-style absolute paths (leading /) to ensure consistent rejection on all platforms including Windows - update_test.go: Remove skipOnWin flag now that / paths are rejected on all platforms - install.ps1: Fix comment mentioning nonexistent -SkipChecksum flag - install.ps1: Parse checksum lines more robustly to handle * prefix (binary mode) and ./ prefix (relative path) in SHA256SUMS entries Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
OK, it's alive! |
wesm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive Windows support improvements plus related fixes discovered during testing.
Windows Installation
scripts/install.ps1for native Windows installation via PowerShellROBOREV_SKIP_CHECKSUMto bypass)*prefix (binary mode) and./prefix in checksum filesWindows ARM64
Codex Agent Fix (All Platforms)
Config Hot-Reload Improvements
Path Sanitization
/etc/passwd) on all platformsInstallation Command
Test Plan
🤖 Generated with Claude Code