Skip to content

Fix parsing 6S output with values prinated with astersisk #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrzejbartoszek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix parsing 6S output with values prinated with astersisk #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Py6S/outputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,17 @@ def __dir__(self):
def extract_results(self):
"""Extract the results from the text output of the model and place them in the ``values`` dictionary."""

# Remove all of the *'s from the text as they just make it look pretty
# Remove all of the *'s forming tables in the text as they just make it look pretty
# and get in the way of analysing the output
fulltext = self.fulltext.replace("*", "")
lines = []
for orig_line in self.fulltext.splitlines():
lines.append(orig_line.strip("*"))

# Split into lines
lines = fulltext.splitlines()

# There should be hundreds of lines for a full 6S run - so if there are
# less than 10 then it suggests something has gone seriously wrong
if len(lines) < 10:
print(fulltext)
print(self.fulltext)
raise OutputParsingError(
"6S didn't return a full output. See raw 6S output above for "
"more information and check for invalid parameter inputs"
Expand Down