fix: handle zero input case in FastSqrt function#6
Open
willll wants to merge 1 commit into
Open
Conversation
Owner
|
I skipped the zero check on purpose to avoid the branch penalty on the SH2, which can really bite in hot paths. What do you think about making it optional via a template argument and if constexpr? That way we keep it zero-cost by default but still provide the option for whoever needs the extra safety. |
Collaborator
Author
|
Hi @robertoduarte, a template parameter similar to Fx::Sqrt() ? |
Owner
Yes that sounds good! |
robertoduarte
force-pushed
the
main
branch
4 times, most recently
from
a1001cf to
ca2da42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.