Remove unneeded quote escaping inside `` #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please add signed-off-by to your commit and rebase, then I'll merge |
Double quotes don't need to be escaped inside Bash command substitution. Also switch to the more modern $(), easier for humans to parse (and which happens to be less forgiving about such extra backslash escapes). Signed-off-by: Quentin Minster <quentin@minster.io>
Author
|
I have no idea if I'm doing things correctly with git but here you go, the branch seems rebased and the commit is signed-off-by. :) |
Owner
|
Already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double quotes don't need to be escaped inside Bash command substitution (either
` `or$()). However the current code works since` `behaves specially wrt. backslashes (see "Command Substitution" inman bash). (That is not the case with$(), as Sabayon/genkernel-next#49 shows -- genkernel-next upgraded the` `substitution to a$()one.)Still, since the escapes aren't needed, and break
$(), I suggest they be removed. Also, I upgraded the substitution to a$()one, which is IMO easier for humans to parse (in general, not necessarily in this particular case).