Skip to content

Skip experimental packets (tags 60-63) in permissive key import mode#2385

Open
kaie wants to merge 2 commits into
rnpgp:mainfrom
kaie:fix-experimental-packet-import
Open

Skip experimental packets (tags 60-63) in permissive key import mode#2385
kaie wants to merge 2 commits into
rnpgp:mainfrom
kaie:fix-experimental-packet-import

Conversation

@kaie
Copy link
Copy Markdown
Contributor

@kaie kaie commented Mar 24, 2026

Fixes: #2379

@kaie
Copy link
Copy Markdown
Contributor Author

kaie commented Mar 24, 2026

FYI, the test key was created using the following approach:

Used existing test key (dsa-eg-pub.asc), decoded it from ASCII armor to binary, then appended a manually constructed experimental packet:

  • Tag byte: 0xFC = 0xC0 | 60 — new-format packet header with tag 60
  • Length byte: 0x04 — 4 bytes of content follow
  • Content: 0xDE 0xAD 0xBE 0xEF — arbitrary placeholder bytes

Then re-armored the result (base64 + CRC24 checksum) back into a .asc file.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.46%. Comparing base (6f8a677) to head (7679cfc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         126      126           
  Lines       22711    22715    +4     
=======================================
+ Hits        19409    19413    +4     
  Misses       3302     3302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kaie and others added 2 commits May 19, 2026 15:43
Fixes: rnpgp#2379

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@kaie kaie force-pushed the fix-experimental-packet-import branch from cc8d63e to 7679cfc Compare May 19, 2026 13:44
Copy link
Copy Markdown
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ni4 ni4 requested review from maxirmx and ronaldtse May 23, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to import key with attached packet of uknown packet number 60 even in permissive mode.

3 participants