Skip to content

Fix layout issue where MarkerViews disappear #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scharron wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix layout issue where MarkerViews disappear #4212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXMarkerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,13 @@ class RNMBXMarkerView(context: Context?, private val mManager: RNMBXMarkerViewMa
mMapView?.offscreenAnnotationViewContainer?.addView(view)
mMapView?.offscreenAnnotationViewContainer?.removeView(view)
}


if (view.width == 0 || view.height == 0) {
// Fixes https://github.com/rnmapbox/maps/issues/4206
// Wait for the next layout via onLayoutChange
return
}

Comment on lines +122 to +128
Comment on lines +122 to +128
val options = getOptions()

val content = view as? RNMBXMarkerViewContent;
Expand Down Expand Up @@ -209,4 +215,4 @@ class RNMBXMarkerView(context: Context?, private val mManager: RNMBXMarkerViewMa
}

// endregion
}
}
Loading