feat: add minPitch support for MapView component#4190
Open
kevindice wants to merge 2 commits intornmapbox:mainfrom
Open
feat: add minPitch support for MapView component#4190kevindice wants to merge 2 commits intornmapbox:mainfrom
minPitch support for MapView component#4190kevindice wants to merge 2 commits intornmapbox:mainfrom
Conversation
kevindice
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
kevindice
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
kevindice
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
minPitchsupport for theMapViewcomponent.My use case is for a ski area map with 3d terrain, so constraining the view with a minimum pitch is desired. We've had a
yarn patchin place adding minPitch for a while but wanted to help upstream this.Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)