chore(android): remove old architecture code #4128
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since @rnmapbox/maps 10.3.0 only supports React Native's new architecture, this removes all old architecture related code from Android: - Delete android/src/main/old-arch directory with generated specs - Remove isNewArchitectureEnabled() checks from build.gradle - Remove IS_NEW_ARCHITECTURE_ENABLED BuildConfig field - Always apply com.facebook.react plugin (required for new arch) - Simplify ViewTagResolver to always use FABRIC UIManager - Remove old arch event emission fallback in RNMBXLocationModule - Update RNMBXPackage to always use isTurboModule=true for TurboModules - Delete unused EventEmitter.java (was only used for old arch events) - Delete scripts/codegen-old-arch.js and remove from autogenerate.mjs - Update CONTRIBUTING.md to remove old-arch references The new architecture codegen by React Native's Gradle plugin now generates the required specs during build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @rnmapbox/maps 10.3.0 only supports React Native's new architecture, this removes all old architecture related code from Android:
The new architecture codegen by React Native's Gradle plugin now generates the required specs during build.
Description
Fixes #
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing