-
-
Notifications
You must be signed in to change notification settings - Fork 926
Fix android coordinates #4116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davor-bauk-sh
wants to merge
4
commits into
rnmapbox:main
Choose a base branch
from
davor-bauk-sh:fix-android-coordinates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix android coordinates #4116
davor-bauk-sh
wants to merge
4
commits into
rnmapbox:main
from
davor-bauk-sh:fix-android-coordinates
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db68a06 to
2a0b049
Compare
2a0b049 to
3d5f7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4115
Commit 1:
chore: example for testing screen coordinatesAdded an example under "Map > Screen Coordinates" (/example/src/examples/Map/ScreenCoordinates.tsx`)
Buggy behavior on Android can be observed by resetting to this commit
Commit 2:
fix(android): screen coordinate conversion on androidFixed conversion between density-independent pixels (as expected by the JS layer) and physical pixels (as expected by the native Android Mapbox SDK)
Replaced usage of
PointFwithScreenCoordinatesandRectFwithScreenBoxto avoid loss of precision when converting betweenfloatandDouble.In JS, I added a
ScreenPointPayloadtype foronPressandonLongPressevents.Commit 3:
fix(ios): avoid loss of precision Double -> Float -> CGFloatFixed instances of double conversion
Double->Float->CGFloat(which is backed byDouble)Commit 4:
fix: improve docsModified JSDocs to provide more information about array parameters and return values (e.g.
[x, y],[top, left, bottom, right],[lon, lat],[minLon, minLat, maxLon, maxLat])Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)