Skip to content

Execution::Next: add as_default: true option, run entire test suite with it#5619

Open
rmosolgo wants to merge 81 commits intomasterfrom
next-as-default-option
Open

Execution::Next: add as_default: true option, run entire test suite with it#5619
rmosolgo wants to merge 81 commits intomasterfrom
next-as-default-option

Conversation

@rmosolgo
Copy link
Copy Markdown
Owner

@rmosolgo rmosolgo commented May 1, 2026

use GraphQL::Execution::Next, as_default: true will make Schema.execute(...) use Execution::Next.

Expanding CI coverage to all files ... there could be a lot of loose ends to follow up here 😅

TODO:

  • ResolveTypeStep: properly batch these. Initialize a step when needed here.
  • FieldResolveStep shortcuts when there's an error in arguments. Right now it goes three ways: a conditional in build_arguments, an early conditional in execute_field, and outside calls to loaded_argument_unauthorized. The fact that this is here three times is totally a smell. How can this data structure and flow be improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant