fix: mock empty slice for not found #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a variable is bound via OPTIONAL MATCH, its properties can be null even if the schema marks them as required. This change tracks whether each binding came from OPTIONAL MATCH and uses that to force Required=false for return fields from optional bindings. Changes: - Add 'optional' bool field to variableBinding struct - Pass optional flag through extractBindings* functions - Update lookupFieldFromExpression to return binding for optional check - Force Required=false when binding.optional is true
Complex expressions (functions, arithmetic, CASE, aggregates, etc.) now default to nullable (Required: false) since we can't statically determine if they might return null. Only simple 'variable.property' patterns on non-optional bindings will use the schema's Required field. Changes: - Flip default from required=true to required=false in extractProjectionItem - 7 new test cases for bailout patterns (function, CASE, aggregate, list index, chained access) - Update existing tests to expect conservative behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mocks currently return a slice with a single zero/nil-value result when all expected outputs are
null(the "not found" case). Service code that checkslen(results) == 0fails.Solution
In Go mock codegen, detect test cases where all output fields are explicitly null and emit an empty slice return for slice-returning result structs.
Changes
language/go/mock.go: return[]*Result{}whenReturnsSliceand all outputs are nulllanguage/go/mock.go: factor output lookup for reuse in null detectionlanguage/go/mock_test.go: add regression test for all-null output → empty slice