Wait for apt lists lock before update#5
Open
rjayasin wants to merge 1 commit into
Open
Conversation
DPkg::Lock::Timeout only blocks on the dpkg lock used by install/ upgrade, not the apt lists lock taken by `apt-get update`. When unattended-upgrades is running its own `apt-get update`, our update still fails with "Could not get lock /var/lib/apt/lists/lock". Reintroduce wait_for_apt and call it before `apt-get update`. The DPkg::Lock::Timeout option still handles install/upgrade/autoremove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DPkg::Lock::Timeout=-1only blocks on the dpkg lock used by install/upgrade, not the apt lists lock taken byapt-get update. Whenunattended-upgradesruns its ownapt-get update, ours still fails withCould not get lock /var/lib/apt/lists/lock.wait_for_apthelper that polls the relevant lock files viafuserand calls it beforeapt-get update.DPkg::Lock::Timeoutstill handles install/upgrade/autoremove.Test plan
setup_linux.shon a fresh Ubuntu box immediately after boot (whileapt-daily/unattended-upgradesis still active) and confirm it waits instead of erroring out on the lists lock.setup_linux.shon an idle system and confirm no regression (no spurious waits, completes normally).Generated by Claude Code