feat(providers): add base image support and improve forward compatibility#269
Open
NathanFlurry wants to merge 2 commits intomainfrom
Open
feat(providers): add base image support and improve forward compatibility#269NathanFlurry wants to merge 2 commits intomainfrom
NathanFlurry wants to merge 2 commits intomainfrom
Conversation
…lity Add support for configuring base images across all compute providers: - E2B: Accept optional `template` parameter to select custom templates - Modal: Accept optional `image` parameter (string or Image object) for base images - ComputeSDK: Expand `create` override to accept full CreateSandboxOptions payload (image, templateId, etc.) - Daytona: Improve type safety for `image` option Improve forward compatibility by making all `create` overrides accept full Partial SDK types, allowing any new provider fields to flow through without code changes. Fix Modal provider bug where `encryptedPorts` was hardcoded and would clobber user-provided values; now merges additional ports instead. Update docs and examples to demonstrate base image configuration for E2B, Modal, and ComputeSDK. Add comprehensive provider lifecycle tests for Modal and ComputeSDK, including template and image passthrough verification. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
🚅 Deployed to the sandbox-agent-pr-269 environment in sandbox-agent
|
The `-full` base image already includes sandbox-agent and all agents pre-installed. Remove redundant apt-get, install script, and install-agent dockerfile commands from the Modal provider. Also allow overriding the default image via SANDBOX_AGENT_IMAGE env var across all providers for testing with different published versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for configuring base images across all compute providers while improving forward compatibility of provider SDKs. E2B now accepts an optional
templateparameter, Modal accepts an optionalimageparameter, and ComputeSDK'screateoverride now forwards the full SDK options. Fixed a Modal provider bug whereencryptedPortswas hardcoded and would overwrite user values.Changes
templateparameter to provider options for custom template selectionimageparameter (string or Image object) for base image configuration, merge additional encrypted ports instead of hardcodingcreateoverride from minimal interface to fullPartial<CreateSandboxOptions>passthroughimageoption using SDK type referenceTest Plan