chore: clean up types

[MasterPtato]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[railway-app]

🚅 Deployed to the rivet-pr-4999 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
website	😴 Sleeping (View Logs)	Web	May 8, 2026 at 12:37 am
frontend-cloud	❌ Build Failed (View Logs)	Web	May 8, 2026 at 12:28 am
frontend-inspector	❌ Build Failed (View Logs)	Web	May 8, 2026 at 12:28 am
ladle	❌ Build Failed (View Logs)	Web	May 8, 2026 at 12:27 am
mcp-hub	✅ Success (View Logs)	Web	May 8, 2026 at 12:27 am
kitchen-sink	❌ Build Failed (View Logs)	Web	May 8, 2026 at 12:27 am

[MasterPtato]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(vbare): add conversion boilerplate generator, fix envoy protocol conversion #5000
• chore: clean up types #4999 👈 (View in Graphite)
• chore: clean up err tracker wf, ignore silenced wf #4979
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review — PR #4999: chore: clean up types

Overview: Small cleanup PR (+11/−12 lines) that removes a re-export from the epoxy crate and updates call sites to reference epoxy_protocol::protocol directly. Also fixes terminology in doc comments and adds a tracing span to an async block.

---

engine/packages/epoxy/src/lib.rs — removal of pub use epoxy_protocol::protocol

Issue: Test files still reference epoxy::protocol via the removed re-export and will fail to compile.

• engine/packages/epoxy/tests/consensus_regressions.rs:8 — use epoxy::protocol::{...}
• engine/packages/epoxy/tests/kv.rs:114,122,187,193 — epoxy::protocol::ChangelogEntry

These files need updating to use epoxy_protocol::protocol directly (the same pattern already used throughout epoxy/src/):

// consensus_regressions.rs
use epoxy_protocol::protocol::{
    self, AcceptRequest, AcceptResponse, CommitRequest, CommitResponse, PrepareRequest,
    PrepareResponse, Request, RequestKind, ResponseKind,
};

// kv.rs
epoxy_protocol::protocol::ChangelogEntry { ... }

---

engine/packages/config/src/config/runtime.rs — "millecores" typo

"millecores" is not the standard term. The industry-standard unit (used by Kubernetes and cgroups) is "millicores" (milli = 1/1000 of a core). This PR changed millicores → millecores, which is a misspelling. The same incorrect change appears in engine/artifacts/config-schema.json.

The "permille" fix (replacing "permilli") is correct — that is the right term.

---

engine/packages/pegboard-outbound/src/lib.rs — .instrument(...) on async block

Correct. The async block becomes an instrumented future; the span will be entered and exited on each poll within the tokio::select!.

---

epoxy::protocol → epoxy_protocol::protocol call-site updates

All four updated files (api-peer/src/internal.rs, pegboard/src/ops/actor/get_reservation_for_key.rs, pegboard/src/workflows/actor/keys.rs, pegboard/src/workflows/actor2/keys.rs) are correct and consistent with how epoxy/src/ already imports from epoxy_protocol.

---

Summary

Change	Verdict
Remove pub use epoxy_protocol::protocol re-export	Intent correct, but breaks test compilation — test files need updating
millicores → millecores	Should be reverted; "millicores" is the correct spelling
permilli → permille	Correct fix
.instrument(...) on stream_handler	Correct
epoxy::protocol → epoxy_protocol::protocol in call sites	Correct

Two items need fixing before merge:

1. Update engine/packages/epoxy/tests/consensus_regressions.rs and engine/packages/epoxy/tests/kv.rs to use epoxy_protocol::protocol instead of the removed epoxy::protocol re-export.
2. Revert millecores back to millicores in engine/packages/config/src/config/runtime.rs and engine/artifacts/config-schema.json.