Skip to content

fix(depot): add ltx decode diagnostics #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
May 5, 2026
Merged

fix(depot): add ltx decode diagnostics #4953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions engine/packages/depot/src/conveyer/read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,19 @@ impl Db {
.with_context(|| format!("missing source blob for page {pgno}"))?;

if !decoded_blobs.contains_key(source_key) {
let decoded = decode_ltx_v3(blob)
.with_context(|| format!("decode source blob for page {pgno}"))?;
let decoded = decode_ltx_v3(blob).with_context(|| {
let len = blob.len();
let head_n = len.min(64);
let tail_start = len.saturating_sub(64);
format!(
"decode source blob for page {pgno}; \
source_key={}; len={}; head={}; tail={}",
crate::compaction::shared::hex_lower(source_key),
len,
crate::compaction::shared::hex_lower(&blob[..head_n]),
crate::compaction::shared::hex_lower(&blob[tail_start..]),
)
})?;
decoded_blobs.insert(source_key.clone(), decoded);
}

Expand Down
14 changes: 12 additions & 2 deletions engine/packages/depot/src/conveyer/read/cold.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,18 @@ impl Db {
let bytes = loaded_objects
.get(object_key)
.expect("cold object should be loaded before decode");
let decoded = decode_ltx_v3(bytes)
.with_context(|| format!("decode sqlite cold layer {object_key}"))?;
let decoded = decode_ltx_v3(bytes).with_context(|| {
let len = bytes.len();
let head_n = len.min(64);
let tail_start = len.saturating_sub(64);
format!(
"decode sqlite cold layer {object_key}; \
len={}; head={}; tail={}",
len,
crate::compaction::shared::hex_lower(&bytes[..head_n]),
crate::compaction::shared::hex_lower(&bytes[tail_start..]),
)
})?;
decoded_objects.insert(object_key.to_string(), decoded);
}

Expand Down
Loading