Skip to content

test(rivetkit): enable driver lifecycle regressions #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
May 5, 2026
Merged

test(rivetkit): enable driver lifecycle regressions #4941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions rivetkit-typescript/packages/rivetkit/tests/driver/actor-lifecycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,7 @@ describeDriverMatrix("Actor Lifecycle", (driverTestConfig) => {
expect(elapsedMs).toBeLessThan(1_500);
}, 10_000);

// TODO(#4706): Root-cause destroy-during-start lifecycle ordering and re-enable this coverage.
test.skip("onDestroy is called even when actor is destroyed during start", async (c) => {
test("onDestroy is called even when actor is destroyed during start", async (c) => {
const { client } = await setupDriverTest(c, driverTestConfig);

const actorKey = `test-ondestroy-during-start-${Date.now()}`;
Expand All @@ -336,9 +335,19 @@ describeDriverMatrix("Actor Lifecycle", (driverTestConfig) => {
const statePromise = actor.getState();
await actor.destroy();

// Verify onDestroy was called (requires actor to be started)
const state = await statePromise;
expect(state.destroyCalled).toBe(true);
expect(state.startCompleted).toBe(true);

const observer = client.lifecycleObserver.getOrCreate([
"observer",
]);
const events = await observer.getEvents();
expect(events).toContainEqual(
expect.objectContaining({
actorKey,
event: "destroy",
}),
);
});
});
});
3 changes: 1 addition & 2 deletions rivetkit-typescript/packages/rivetkit/tests/driver/actor-sleep.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ describeDriverMatrix("Actor Sleep", (driverTestConfig) => {
);
});

// TODO(#4707): Root-cause persistent connection sleep-state behavior and re-enable this coverage.
test.skip("actor sleep persists state with connect", async (c) => {
test("actor sleep persists state with connect", async (c) => {
const { client } = await setupDriverTest(c, driverTestConfig);

// Create actor with persistent connection
Expand Down
3 changes: 1 addition & 2 deletions rivetkit-typescript/packages/rivetkit/tests/driver/actor-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,7 @@ describeDriverMatrix("Actor Workflow", (driverTestConfig) => {
});
});

// TODO(#4708): Root-cause failed-step sleep-vs-run-error behavior and re-enable this coverage.
test.skip("failed workflow steps sleep instead of surfacing as run errors", async (c) => {
test("failed workflow steps sleep instead of surfacing as run errors", async (c) => {
const { client } = await setupDriverTest(c, driverTestConfig);
const actor = client.workflowFailedStepActor.getOrCreate([
"workflow-failed-step",
Expand Down
Loading