Skip to content

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@railway-app
Copy link

railway-app bot commented Jan 14, 2026

🚅 Deployed to the rivet-pr-3893 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Jan 14, 2026 at 8:43 am
frontend-cloud 😴 Sleeping (View Logs) Web Jan 14, 2026 at 8:43 am
website 😴 Sleeping (View Logs) Web Jan 14, 2026 at 8:43 am

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3893 January 14, 2026 08:35 Destroyed
Copy link
Member Author

NathanFlurry commented Jan 14, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Jan 14, 2026

PR Review: chore(rivetkit): update welcome message

Summary

This PR refactors the welcome message display in the RivetKit runtime to provide clearer and more comprehensive information about the runtime configuration. The changes improve user experience by better organizing the startup information.

✅ Positive Aspects

  1. Better Code Organization: The introduction of the logLine() helper function (lines 25-28) eliminates code duplication and makes the output formatting consistent.

  2. Improved Information Architecture: The new structure is more logical:

    • Namespace (when non-default)
    • Backend endpoint with type annotation
    • Public client endpoint (serverless only)
    • Inspector URL
    • Actor count
    • Driver-specific properties
  3. Enhanced Clarity: Adding endpoint type annotations ("local native", "local manager", "remote") helps users understand their configuration at a glance.

  4. New Useful Information: Displaying the actor count provides immediate feedback about registered actors.

🔍 Code Quality Observations

  1. Good: The logLine() function properly handles padding with Math.max(0, 13 - label.length) to prevent negative padding values.

  2. Good: The conditional display logic is well-structured and follows clear business rules.

  3. Minor Style Consideration: The padding value 13 is a magic number. Consider adding a comment explaining why 13 characters was chosen, or extract it as a named constant:

    const LABEL_WIDTH = 13; // Chosen to accommodate longest label "Namespace"

🤔 Questions & Suggestions

  1. Endpoint Display Logic (lines 224-230): The current logic shows the endpoint whenever it exists, but the type detection might not cover all cases:

    • What happens if neither spawnEngine nor serveManager is true, but endpoint is set? It would show "remote", which seems correct.
    • Consider if this logic is exhaustive for all configuration combinations.
  2. Consistency: The PR changes "Endpoint" to show the backend endpoint, and "Client" for the public endpoint. This is clearer, but verify that this terminology aligns with how these concepts are documented elsewhere in RivetKit.

  3. Actor Count Display (line 245): Showing the count is useful, but consider also showing it in the startup kind line:

    console.log(
      `  RivetKit ${pkg.version} (${this.#driver.displayName} - ${this.#startKind === "serverless" ? "Serverless" : "Runner"} - ${actorCount} actors)`,
    );

    Though this might make the line too long, so the current approach is fine.

🐛 Potential Issues

None identified - The code appears functionally correct and maintains backward compatibility while improving the user experience.

🔒 Security Considerations

No security concerns - This change only affects console output formatting and doesn't introduce any security vulnerabilities.

⚡ Performance Considerations

No performance concerns - The changes are minimal and only affect startup logging, which happens once. The logLine() helper is efficient.

🧪 Test Coverage

Consideration: Since this PR modifies display output:

  • Consider if there are snapshot tests or integration tests that verify the welcome message format
  • If tests exist that assert specific console output, they may need updating
  • The changes are cosmetic and low-risk, so extensive testing may not be necessary

📝 Documentation

No documentation updates appear necessary since this is an internal formatting change. However, if there are screenshots or examples in documentation showing the welcome message, those might benefit from updates.

✨ Verdict

Approved - This is a solid improvement to the developer experience. The code is clean, well-structured, and enhances clarity without introducing risks. The only minor suggestion is to consider documenting the magic number 13 for the padding width.

The refactoring successfully achieves the goal of updating the welcome message to be more informative and better organized.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 14, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3893

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3893

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3893

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3893

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3893

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3893

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3893

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3893

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3893

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3893

commit: 46691f2

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 14, 2026

Merge activity

  • Jan 14, 8:52 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jan 14, 8:52 PM UTC: CI is running for this pull request on a draft pull request (#3898) due to your merge queue CI optimization settings.
  • Jan 14, 8:53 PM UTC: Merged by the Graphite merge queue via draft PR: #3898.

graphite-app bot pushed a commit that referenced this pull request Jan 14, 2026
@graphite-app graphite-app bot closed this Jan 14, 2026
@graphite-app graphite-app bot deleted the 01-14-chore_rivetkit_update_welcome_message branch January 14, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants