fix(dashboard): use ineligible icon for runners #3742

jog1t · 2026-01-02T23:33:48Z

TL;DR

Updated the offline runner status indicator to use a warning triangle icon with improved tooltip text.

What changed?

Imported faExclamationTriangle icon from Font Awesome
Changed the offline runner status icon from faSignalAlt to faExclamationTriangle
Updated the tooltip text from "Last ping X time ago" to "Offline (last seen X time ago)" for better clarity

How to test?

Navigate to the runners table view
Wait for a runner to go offline (or simulate an offline runner)
Verify that the offline runner now displays a warning triangle icon instead of the signal icon
Hover over the icon to confirm the tooltip now shows "Offline (last seen X time ago)"

Why make this change?

The warning triangle icon more clearly communicates an error state compared to the previous signal icon. The updated tooltip text also explicitly states that the runner is offline, making the status more immediately understandable to users.

vercel · 2026-01-02T23:33:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Updated (UTC)
rivet-cloud	Error	Jan 9, 2026 9:38pm
rivet-inspector	Error	Jan 9, 2026 9:38pm
rivetkit-serverless	Error	Jan 9, 2026 9:38pm

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
rivet-site	Ignored	Preview	Jan 9, 2026 9:38pm

jog1t · 2026-01-02T23:33:59Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-01-02T23:35:55Z

PR Review: Fix Dashboard Runner Status Icon

Summary

This PR updates the offline runner status indicator from a signal icon to a warning triangle icon and improves the tooltip text. The change is small, focused, and improves UX clarity.

✅ Positives

Better UX Communication - The exclamation triangle (faExclamationTriangle) more clearly conveys an error/warning state compared to the signal icon
Improved Tooltip Text - "Offline (last seen X time ago)" is more explicit than "Last ping X time ago"
Minimal Scope - The change is focused and doesn't introduce unnecessary modifications
Consistent Styling - Maintains the same text-red-500 color class for error states

📝 Code Quality Observations

Import Management (frontend/src/app/runners-table.tsx:2)
The faExclamationTriangle import is correctly added at the top of the file following the existing import pattern. Good adherence to code organization.

Formatting (frontend/src/app/runners-table.tsx:184-188)
The tooltip content formatting change improves readability by breaking the string into multiple lines. The formatting looks good.

🤔 Considerations

Unused Import
- faSignalAlt is now only used for the poor connection state (lines 241-242), not for offline runners
- However, this import is still needed for the low signal strength indicator in the fallback case
- ✅ No cleanup needed
Icon Semantics
- The warning triangle is semantically correct for an offline/error state
- This aligns with common UI patterns where triangles indicate warnings/errors
- ✅ Good choice
Magic Number (frontend/src/app/runners-table.tsx:181)
- The 15000ms (15 seconds) threshold is hardcoded
- While this isn't changed in this PR, consider extracting to a named constant in future work
- For example: const RUNNER_OFFLINE_THRESHOLD_MS = 15000;
- This is a future enhancement suggestion, not a blocker for this PR

🧪 Testing Considerations

The PR description provides clear testing steps. Consider these additional test scenarios:

Edge Case: Runner that just crossed the 15-second threshold
Accessibility: Screen reader announcement for the status change
Visual Consistency: Verify the triangle icon size matches other status icons in the same column

🔒 Security & Performance

✅ No security concerns
✅ No performance impact (same render logic, just different icon/text)
✅ No new dependencies introduced

📊 Overall Assessment

Verdict: ✅ Approved

This is a well-scoped UI improvement that enhances clarity without introducing risk. The code quality is good and follows existing patterns in the codebase.

Recommendation: Merge after successful testing of the visual changes.

💡 Optional Future Enhancements

These are not required for this PR but could be considered for future work:

Extract the 15-second offline threshold to a named constant
Consider adding a brief CSS transition when status changes for smoother UX
Consider adding automated visual regression tests for status icon changes

Review completed by Claude Code - 2026-01-09 21:39:44 UTC

graphite-app · 2026-01-02T23:40:13Z

Graphite Automations

"Test" took an action on this PR • (01/02/26)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

pkg-pr-new · 2026-01-09T00:06:25Z

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3742

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3742

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3742

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3742

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3742

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3742

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3742

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3742

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3742

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3742

commit: d8be1a7

graphite-app · 2026-01-09T21:41:44Z

Merge activity

Jan 9, 9:41 PM UTC: jog1t added this pull request to the Graphite merge queue.
Jan 9, 9:42 PM UTC: CI is running for this pull request on a draft pull request (#3805) due to your merge queue CI optimization settings.
Jan 9, 9:42 PM UTC: Merged by the Graphite merge queue via draft PR: #3805.

### TL;DR Updated the offline runner status indicator to use a warning triangle icon with improved tooltip text. ### What changed? - Imported `faExclamationTriangle` icon from Font Awesome - Changed the offline runner status icon from `faSignalAlt` to `faExclamationTriangle` - Updated the tooltip text from "Last ping X time ago" to "Offline (last seen X time ago)" for better clarity ### How to test? 1. Navigate to the runners table view 2. Wait for a runner to go offline (or simulate an offline runner) 3. Verify that the offline runner now displays a warning triangle icon instead of the signal icon 4. Hover over the icon to confirm the tooltip now shows "Offline (last seen X time ago)" ### Why make this change? The warning triangle icon more clearly communicates an error state compared to the previous signal icon. The updated tooltip text also explicitly states that the runner is offline, making the status more immediately understandable to users.

This was referenced Jan 2, 2026

chore(gas): add support for find_workflows #3739

Closed

feat(engine): return error for pending actors #3730

Closed

This was referenced Jan 2, 2026

chore: update engine-full sdk #3740

Open

feat(dashboard): show runner pool errors #3741

Closed

vercel bot deployed to Preview – rivet-inspector January 2, 2026 23:36 View deployment

jog1t marked this pull request as ready for review January 2, 2026 23:37

graphite-app bot assigned jog1t Jan 2, 2026

jog1t mentioned this pull request Jan 2, 2026

feat(dashboard): surface actor errors in ui #3743

Closed

jog1t force-pushed the 01-03-fix_dash_use_ineligible_icon_for_runners branch from f6af542 to a4972a8 Compare January 3, 2026 00:05

jog1t force-pushed the 01-03-feat_dash_show_runner_pool_errors branch from f941b79 to 70e750a Compare January 3, 2026 00:05

vercel bot had a problem deploying to Preview – rivetkit-serverless January 3, 2026 00:06 Failure

vercel bot deployed to Preview – rivet-inspector January 3, 2026 00:08 View deployment

jog1t force-pushed the 01-03-feat_dash_show_runner_pool_errors branch from 70e750a to 2658d38 Compare January 9, 2026 00:04

jog1t force-pushed the 01-03-fix_dash_use_ineligible_icon_for_runners branch from a4972a8 to d8be1a7 Compare January 9, 2026 00:04

NathanFlurry approved these changes Jan 9, 2026

View reviewed changes

jog1t mentioned this pull request Jan 9, 2026

feat(dashboard): editable serverless configs #3765

Closed

jog1t changed the title ~~fix(dash): use ineligible icon for runners~~ fix(dashboard): use ineligible icon for runners Jan 9, 2026

fix(dash): use ineligible icon for runners

5435aff

jog1t force-pushed the 01-03-feat_dash_show_runner_pool_errors branch from 2658d38 to 61e5c6a Compare January 9, 2026 21:38

jog1t force-pushed the 01-03-fix_dash_use_ineligible_icon_for_runners branch from d8be1a7 to 5435aff Compare January 9, 2026 21:38

vercel bot had a problem deploying to Preview – rivetkit-serverless January 9, 2026 21:38 Failure

vercel bot had a problem deploying to Preview – rivet-cloud January 9, 2026 21:38 Failure

vercel bot had a problem deploying to Preview – rivet-inspector January 9, 2026 21:38 Failure

graphite-app bot closed this Jan 9, 2026

graphite-app bot deleted the 01-03-fix_dash_use_ineligible_icon_for_runners branch January 9, 2026 21:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(dashboard): use ineligible icon for runners #3742

fix(dashboard): use ineligible icon for runners #3742

Uh oh!

jog1t commented Jan 2, 2026 •

edited

Loading

Uh oh!

vercel bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

jog1t commented Jan 2, 2026 •

edited

Loading

Uh oh!

claude bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 2, 2026

Uh oh!

pkg-pr-new bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(dashboard): use ineligible icon for runners #3742

fix(dashboard): use ineligible icon for runners #3742

Uh oh!

Conversation

jog1t commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

What changed?

How to test?

Why make this change?

Uh oh!

vercel bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jog1t commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

claude bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: Fix Dashboard Runner Status Icon

Summary

✅ Positives

📝 Code Quality Observations

🤔 Considerations

🧪 Testing Considerations

🔒 Security & Performance

📊 Overall Assessment

💡 Optional Future Enhancements

Uh oh!

graphite-app bot commented Jan 2, 2026

Graphite Automations

Uh oh!

pkg-pr-new bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jog1t commented Jan 2, 2026 •

edited

Loading

vercel bot commented Jan 2, 2026 •

edited

Loading

jog1t commented Jan 2, 2026 •

edited

Loading

claude bot commented Jan 2, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 9, 2026 •

edited

Loading

graphite-app bot commented Jan 9, 2026 •

edited

Loading