Skip to content

Correct references to SimpleArgs that should be SortArgs #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Apr 12, 2025
Merged

Correct references to SimpleArgs that should be SortArgs #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class SortArgs
def to_json = JSON.dump({strings: strings})
end

insert_res = client.insert(SimpleArgs.new(strings: ["whale", "tiger", "bear"]))
insert_res = client.insert(SortArgs.new(strings: ["whale", "tiger", "bear"]))
insert_res.job # inserted job row
```

Expand All @@ -53,7 +53,7 @@ Inserts take an `insert_opts` parameter to customize features of the inserted jo

```ruby
insert_res = client.insert(
SimpleArgs.new(strings: ["whale", "tiger", "bear"]),
SortArgs.new(strings: ["whale", "tiger", "bear"]),
insert_opts: River::InsertOpts.new(
max_attempts: 17,
priority: 3,
Expand Down Expand Up @@ -110,13 +110,13 @@ No extra code is needed to insert jobs from inside a transaction. Just make sure

```ruby
ActiveRecord::Base.transaction do
client.insert(SimpleArgs.new(strings: ["whale", "tiger", "bear"]))
client.insert(SortArgs.new(strings: ["whale", "tiger", "bear"]))
end
```

```ruby
DB.transaction do
client.insert(SimpleArgs.new(strings: ["whale", "tiger", "bear"]))
client.insert(SortArgs.new(strings: ["whale", "tiger", "bear"]))
end
```

Expand Down
Loading