Skip to content

Conversation

@lunohodov
Copy link

@lunohodov lunohodov commented Apr 10, 2025

The examples in README declare a SortArgs class but use one named SimpleArgs. This PR makes the naming consistent.

@lunohodov
Copy link
Author

I just realized this is not a typo and SimpleArgs is part of the gem. Closing.

@lunohodov lunohodov closed this Apr 10, 2025
@brandur
Copy link
Contributor

brandur commented Apr 10, 2025

Yeah, it's just a demo set of args for demonstration purposes. "Sort args" takes a set of strings and sorts them in a background job.

@brandur
Copy link
Contributor

brandur commented Apr 12, 2025

So turns out you were right in that there was something not quite right in here ... fixed some references in #44.

@lunohodov
Copy link
Author

Thanks for getting to the bottom of this. I was confused to see SortArgs declared but not used. My initial thought was this is a typo, a leftover from a previous README iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants