split riverdrivertest.go #1138
Open
split riverdrivertest.go #1138
+5,094
−4,758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bgentry/split-driver-test
branch
from
cb8347d to
5dad2d4
Compare
Instead of a giant 5000 line file, split into smaller files grouped by entity. For job queries where we have many tests, break them into files by query type.
bgentry
force-pushed
the
bgentry/split-driver-test
branch
from
5dad2d4 to
f64e602
Compare
bgentry
commented
Jan 31, 2026
Comment on lines
+106
to
+118
| t.Run("IndexThatDoesNotExistIgnore", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| // Postgres runs the drop with `CONCURRENTLY` so this must use a full | ||
| // schema rather than a transaction block. | ||
| driver, schema := driverWithSchema(ctx, t, nil) | ||
|
|
||
| err := driver.GetExecutor().IndexDropIfExists(ctx, &riverdriver.IndexDropIfExistsParams{ | ||
| Index: "does_not_exist", | ||
| Schema: schema, | ||
| }) | ||
| require.NoError(t, err) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
@brandur hmm, this test was actually just an empty block before the split and Codex attempted to fix it. However it can't work in a tx as the other tests do because you can't run DROP INDEX CONCURRENTLY inside a transaction.
I filled it out using the same pattern as the above test to grab a full schema instead of txn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brandur hit a point where I felt like this file is just too unwieldy. Instead of a giant 5000 line file, this splits them into smaller files grouped by entity. For job queries where we have many tests, break them into files by query type.
Let me know if you think this would be an improvement broadly. It's easy to tweak as it's a mostly AI-driven refactor. FWIW I also spun up a separate session and had it cross check every removed line to verify it was moved without being altered (other than setup details)—all good there. ✅