Add font config and asset loading tests#274
Merged
Merged
Conversation
Covers RiveFonts API (loadFont by name/URL, systemFallback, setFallbackFonts, clearFallbackFonts, error path) and referencedAssets loading (font/image assets with explicit types, multiple assets, undefined assets).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds harness tests for two previously untested areas:
Font config (6 tests): loadFont by system name, loadFont by URL, systemFallback, setFallbackFonts with default/weight-specific fonts, clearFallbackFonts, error on invalid font name.
Asset loading (4 tests): referencedAssets with font type, image URL type, multiple asset types, and undefined assets.
Covers HybridRiveFontConfig.swift (was 0%), AssetLoader.swift (was 1%), DataSourceResolver.swift (was 0%), HTTPDataLoader.swift (was 43%).