DO NOT MERGE: native iOS coverage setup (local harness fork)#247
Draft
mfazekas wants to merge 1 commit intofeat/rive-ios-experimentalfrom
Draft
DO NOT MERGE: native iOS coverage setup (local harness fork)#247mfazekas wants to merge 1 commit intofeat/rive-ios-experimentalfrom
mfazekas wants to merge 1 commit intofeat/rive-ios-experimentalfrom
Conversation
Adds coverage-ios dependency and portal resolutions pointing to the local react-native-harness fork (feat/native-ios-coverage branch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge — this PR contains local
file:andportal:references to the react-native-harness fork.What this does
Sets up native iOS code coverage collection using
@react-native-harness/coverage-iosfrom themfazekas/react-native-harnessfork (feat/native-ios-coveragebranch).How to use
Prerequisites: clone the harness fork at
/Users/boga/Work/Margelo/react-native-harnessand check outfeat/native-ios-coverage.Known issue
The
resolve-coverage-pods.mjsscript needsNODE_OPTIONS="--preserve-symlinks"when using portal resolutions. Afteryarn install, manually patchnode_modules/@react-native-harness/coverage-ios/scripts/harness_coverage_hook.rbline 19 to add this. This will be fixed upstream.See
NATIVE_IOS_COVERAGE_INTEGRATION.mdfor full details.