Fix a small todo #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed outdated references to ViewController.swift by updating documentation to reference the actual SwiftUI-based architecture: - Updated project structure to show LiquidGlassView.swift, LiquidGlassHostingController.swift, and SceneDelegate.swift - Changed feature description from UIKit to SwiftUI with liquid glass design - Updated "Key Files" section to document LiquidGlassView.swift instead of ViewController.swift - Updated "Updating App UI" section with correct file references This brings the README in sync with the modern SwiftUI codebase documented in CLAUDE.md.
Removed legacy content.js file that was never actually used by the extension. The project uses declarativeNetRequest for network-level redirects, not content scripts. Changes: - Deleted FreeYT Extension/Resources/content.js (150 lines of unused code) - Updated SafariWebExtensionHandler.swift comment to reflect actual extension files - Updated CLAUDE.md to clarify "No content scripts" architecture The content.js file had several issues: 1. Not referenced in manifest.json (never executed) 2. Used inefficient patterns (2s polling, MutationObserver) 3. Used wrong redirect target (yout-ube.com instead of youtube-nocookie.com) 4. Redundant - all redirects handled by declarativeNetRequest rules This cleanup improves code quality and aligns with the documented Manifest V3 architecture.
rishabhcli
deleted the
claude/fix-todo-mhy5o459kvrw4ymg-011GqrLV61dcPgRmQNTyLMCj
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.