Fix recursive ExceptionObjHolderImpl crash in exception reporting#48
Open
dimohamdy wants to merge 1 commit intorickclephas:masterfrom
Open
Fix recursive ExceptionObjHolderImpl crash in exception reporting#48dimohamdy wants to merge 1 commit intorickclephas:masterfrom
dimohamdy wants to merge 1 commit intorickclephas:masterfrom
Conversation
Add re-entrancy guards and exception handling to prevent crashes when exceptions are thrown during exception conversion or Crashlytics reporting. - Add atomic guard in unhandled exception hook wrapper - Add re-entrancy protection in Crashlytics reporter - Add try-catch fallback in exception conversion to NSException - Prevent recursive termination handler invocation Fixes crash: Fatal Exception: (anonymous namespace)::ExceptionObjHolderImpl
Owner
|
Hey! Could you provide some more details about these crashes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add re-entrancy guards and exception handling to prevent crashes when exceptions are thrown during exception conversion or Crashlytics reporting.
Fixes crash: Fatal Exception: (anonymous namespace)::ExceptionObjHolderImpl