Add support for deploying ComplianceAsCode/compliance-operator #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the whole purpose of compserv is to parse compliance results, we can host the compliance-operator on the same cluster to generate results. This commit adds a new kustomize directory for installing the compliance-operator on the same cluster that the compliance service is running.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jhrozek
reviewed
Sep 16, 2022
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: openshift-compliance |
Collaborator
There was a problem hiding this comment.
Does this work with 4.12? I would assume that you need to add:
+ pod-security.kubernetes.io/audit: privileged
+ pod-security.kubernetes.io/enforce: privileged
+ pod-security.kubernetes.io/warn: privileged
to account for the PSA changes.
(side node: we might want to bump the CI cluster to 4.12 this close to 4.12 feature freeze to catch issues early)
Owner
Author
There was a problem hiding this comment.
Good call - I'm running this on 4.11.
Want me to do that bump here or a separate patch?
Collaborator
|
On Fri, Sep 16, 2022 at 07:41:50AM -0700, Lance Bragstad wrote:
@rhmdnd commented on this pull request.
> @@ -0,0 +1,4 @@
+apiVersion: v1
+kind: Namespace
+metadata:
+ name: openshift-compliance
Good call - I'm running this on 4.11.
Want me to do that bump here or a separate patch?
A separate patch is fine.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the whole purpose of compserv is to parse compliance results, we
can host the compliance-operator on the same cluster to generate
results.
This commit adds a new kustomize directory for installing the
compliance-operator on the same cluster that the compliance service is
running.