Skip to content

Update AWS CLI to 1.18.18 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
max-rocket-internet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update AWS CLI to 1.18.18 #13

max-rocket-internet wants to merge 2 commits into from

Conversation

@max-rocket-internet
Copy link

@max-rocket-internet max-rocket-internet commented Mar 12, 2020 •
edited
Loading

We need version 1.16.210 for STS AssumeRoleWithWebIdentity but might as well just jump to the latest release?

PR Checklist

  • I have tested my build locally
  • I have checked for vulnerabilities in this image

@max-rocket-internet
Update AWS CLI to 1.18.18
59306ef 
We need version [1.16.210](https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst#116210) for STS AssumeRoleWithWebIdentity but might as well just jump to the latest release?
@max-rocket-internet
Copy link
Author

max-rocket-internet commented Mar 12, 2020

@rogersgt 😃

rogersgt
rogersgt suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rogersgt rogersgt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Max. Thanks for your PR! I'm sure you've worked around this by now, but I think we will need to upgrade our python installation to start using awscli ^1.17.x. I think we need at least python 2.7.

rogersgt
rogersgt approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rogersgt rogersgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous comment, we are using python2.7 in this image. (I realize it needs to be upgraded as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogersgt rogersgt rogersgt approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@max-rocket-internet @rogersgt