Merged
Conversation
AWS Lambda added Ruby 3.4 support in March 2025. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@dnorth98 if we are going to be keeping this function we should be adding in rspec tests. |
stairsj
approved these changes
Jan 28, 2026
- Add RSpec tests for lambda.rb functions - Add SimpleCov for coverage reporting - Add CI workflow for tests with coverage threshold - Exclude lambda_layer from rubocop Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Simplecov Report
|
Add minimal permissions block to satisfy CodeQL security scanning. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle updateChanges
template.ymlruby3.2→ruby3.4.ruby-version3.2.2→3.4.1lambda_layer/MakefileRUBY_VERSION = 3.2.0→3.4.0.rubocop.ymlTargetRubyVersion: 3.2→3.4, excludelambda_layer/.github/workflows/style.ymlREADME.mdGemfilerspec,aws-sdk-ssm,simplecovfor testingGemfile.lockNew: RSpec Tests
Added unit tests for
src/lambda.rbwith coverage reporting:get_ssm_parameter- retrieves parameters with decryptionupdate_ssm_parameter- updates parameters with overwritegithub_token_from_ssm- fetches GitHub token from SSMlast_time_checked_from_ssm- returns stored timestamp or defaults to 1 day agoWhy
auditor.rbis not covered: The auditor script is written in a procedural style that executes top-to-bottom when loaded, making it difficult to unit test without refactoring into a class. The lambda.rb functions are well-structured and provide the critical SSM integration logic. Adding tests for auditor.rb would require refactoring it into a testable class structure, which is out of scope for this PR.Compatibility
The codebase was reviewed and is compatible with Ruby 3.4:
frozen_string_literal: trueTest plan
bundle installsucceedsbundle exec rubocoppasses with no offensesbundle exec rspecpasses (5 examples, 0 failures)ruby -csyntax check passesmake buildsucceeds with new runtime🤖 Generated with Claude Code