sending current session id to test observability #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07souravkunda
suggested changes
Feb 21, 2024
| platform: this._platformMeta?.platformName, | ||
| capabilities: caps, | ||
| session_id: sessionId, | ||
| browser: caps.browserName, |
There was a problem hiding this comment.
Suggested change
| browser: caps.browserName, | |
| browser: caps?.browserName, |
| } | ||
|
|
||
| private getIntegrationsObject () { | ||
| const caps = (this._browser as WebdriverIO.Browser).capabilities as WebdriverIO.Capabilities |
There was a problem hiding this comment.
Suggested change
| const caps = (this._browser as WebdriverIO.Browser).capabilities as WebdriverIO.Capabilities | |
| const caps = (this._browser as WebdriverIO.Browser)?.capabilities as WebdriverIO.Capabilities |
|
|
||
| private getIntegrationsObject () { | ||
| const caps = (this._browser as WebdriverIO.Browser).capabilities as WebdriverIO.Capabilities | ||
| const sessionId = (this._browser as WebdriverIO.Browser).sessionId |
There was a problem hiding this comment.
Suggested change
| const sessionId = (this._browser as WebdriverIO.Browser).sessionId | |
| const sessionId = (this._browser as WebdriverIO.Browser)?.sessionId |
…session-id-observability-reload-session-fix "main merge"
sriteja777
approved these changes
Feb 23, 2024
07souravkunda
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers