changes for accessibility automation inbrowserstack service #1

rev-doshi · 2024-02-13T05:22:35Z

Proposed changes

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

* (internal): drop support for Node.js 16 update engines of package.json files * (internal): drop support for Node.js 16 update CONTRIBUTING.md with Node.js 20 as recommendation * (internal): drop support for Node.js 16 update github workflows * (internal): drop support for Node.js 16 update external packages that dropped the support already * (internal): drop support for Node.js 16 resolve PR feedback * Update packages/webdriver/package.json * Update packages/wdio-cucumber-framework/package.json * Update package.json --------- Co-authored-by: Christian Bromann <git@bromann.dev>

…iverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed

…support for Node.js v16 closes webdriverio#11938 fixes webdriverio#11858

fix type issues fix unit tests

* V9 drop support for Node.js 16 (webdriverio#11493) * (internal): drop support for Node.js 16 update engines of package.json files * (internal): drop support for Node.js 16 update CONTRIBUTING.md with Node.js 20 as recommendation * (internal): drop support for Node.js 16 update github workflows * (internal): drop support for Node.js 16 update external packages that dropped the support already * (internal): drop support for Node.js 16 resolve PR feedback * Update packages/webdriver/package.json * Update packages/wdio-cucumber-framework/package.json * Update package.json --------- Co-authored-by: Christian Bromann <git@bromann.dev> * (webdriverio): merge isDisplayed and isDisplayedWithinViewport (webdriverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed * V9 drop support for Node.js 16 (webdriverio#11493) * (internal): drop support for Node.js 16 update engines of package.json files * (internal): drop support for Node.js 16 update CONTRIBUTING.md with Node.js 20 as recommendation * (internal): drop support for Node.js 16 update github workflows * (internal): drop support for Node.js 16 update external packages that dropped the support already * (internal): drop support for Node.js 16 resolve PR feedback * Update packages/webdriver/package.json * Update packages/wdio-cucumber-framework/package.json * Update package.json --------- Co-authored-by: Christian Bromann <git@bromann.dev> * (webdriverio): merge isDisplayed and isDisplayedWithinViewport (webdriverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed * V9 remove jsonWireProtocol * V9 drop support for Node.js 16 (webdriverio#11493) * (internal): drop support for Node.js 16 update engines of package.json files * (internal): drop support for Node.js 16 update CONTRIBUTING.md with Node.js 20 as recommendation * (internal): drop support for Node.js 16 update github workflows * (internal): drop support for Node.js 16 update external packages that dropped the support already * (internal): drop support for Node.js 16 resolve PR feedback * Update packages/webdriver/package.json * Update packages/wdio-cucumber-framework/package.json * Update package.json --------- Co-authored-by: Christian Bromann <git@bromann.dev> * (webdriverio): merge isDisplayed and isDisplayedWithinViewport (webdriverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed * (internal): update some dependencies that couldn't be updated due to support for Node.js v16 closes webdriverio#11938 fixes webdriverio#11858 * (webdriverio): make puppeteer a peer dependency (webdriverio#12103) * (webdriverio): make puppeteer a peer dependency * fix type issues * fix unit tests --------- Co-authored-by: Erwin Heitzman <15839059+erwinheitzman@users.noreply.github.com> Co-authored-by: Christian Bromann <git@bromann.dev>

* V9 drop support for Node.js 16 (webdriverio#11493) * (internal): drop support for Node.js 16 update engines of package.json files * (internal): drop support for Node.js 16 update CONTRIBUTING.md with Node.js 20 as recommendation * (internal): drop support for Node.js 16 update github workflows * (internal): drop support for Node.js 16 update external packages that dropped the support already * (internal): drop support for Node.js 16 resolve PR feedback * Update packages/webdriver/package.json * Update packages/wdio-cucumber-framework/package.json * Update package.json --------- Co-authored-by: Christian Bromann <git@bromann.dev> * (webdriverio): merge isDisplayed and isDisplayedWithinViewport (webdriverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed * V9 drop support for Node.js 16 (webdriverio#11493) * (internal): drop support for Node.js 16 update engines of package.json files * (internal): drop support for Node.js 16 update CONTRIBUTING.md with Node.js 20 as recommendation * (internal): drop support for Node.js 16 update github workflows * (internal): drop support for Node.js 16 update external packages that dropped the support already * (internal): drop support for Node.js 16 resolve PR feedback * Update packages/webdriver/package.json * Update packages/wdio-cucumber-framework/package.json * Update package.json --------- Co-authored-by: Christian Bromann <git@bromann.dev> * (webdriverio): merge isDisplayed and isDisplayedWithinViewport (webdriverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed * Migrating from got to fetch * Migrate got to fetch in packages * migrate got to fetch & update unit test * doc update for proxy setup * rebase and migrate got to fetch in browserstack * Migrate hostname from 0.0.0.0 to localhost * fix unit test by removing headers in safari driver * fix smoke test: update nock to beta * fix launch test for firefox * fix unit test for startGeckodriver * fix firefox executions in node 18 * Incorporating review comments * fix component tests * cleaning up RequestLibOptions * Removing RequestLibOptions & incorporating other review comments * use process from globalThis --------- Co-authored-by: Erwin Heitzman <15839059+erwinheitzman@users.noreply.github.com> Co-authored-by: Christian Bromann <git@bromann.dev>

Bumps [tmp](https://github.com/raszi/node-tmp) from 0.0.33 to 0.2.1. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.0.33...v0.2.1) --- updated-dependencies: - dependency-name: tmp dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [split2](https://github.com/mcollina/split2) from 3.2.2 to 4.2.0. - [Release notes](https://github.com/mcollina/split2/releases) - [Commits](mcollina/split2@v3.2.2...v4.2.0) --- updated-dependencies: - dependency-name: split2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [yauzl](https://github.com/thejoshwolfe/yauzl) from 2.10.0 to 3.0.0. - [Commits](thejoshwolfe/yauzl@2.10.0...3.0.0) --- updated-dependencies: - dependency-name: yauzl dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [change-case](https://github.com/blakeembrey/change-case) from 4.1.2 to 5.4.3. - [Release notes](https://github.com/blakeembrey/change-case/releases) - [Commits](https://github.com/blakeembrey/change-case/compare/change-case@4.1.2...change-case@5.4.3) --- updated-dependencies: - dependency-name: change-case dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updating capabilities for Lamdatest & Browserstack * fix bootstrap & component test

…riverio#12318) * docs: Updated Contributing guide to mention PNPM instead of NPM * docs: Corrected pnpm commands

…ck-accessibility-stability-changes

07souravkunda · 2024-02-28T14:21:31Z

packages/wdio-browserstack-service/src/accessibility-handler.ts

+        if (this._accessibility) {
+            if (Array.isArray(accessibilityScripts.commandsToWrap)) {
+                const that = this
+                accessibilityScripts.commandsToWrap.forEach(async function (command) {


can use arrow function [optional]

07souravkunda · 2024-02-28T14:21:35Z

packages/wdio-browserstack-service/src/accessibility-handler.ts

+                const that = this
+                accessibilityScripts.commandsToWrap.forEach(async function (command) {
+                    if (command.name && command.class) {
+                        await (that._browser as WebdriverIO.Browser).overwriteCommand(command.name, async function (origFunction: Function, ...args: any[]) {


ca use arrow function [optional]

07souravkunda · 2024-02-28T14:23:03Z

packages/wdio-browserstack-service/src/@types/bstack-service-types.d.ts

    interface Browser {
        getAccessibilityResultsSummary: () => Promise<{ [key: string]: any; }>,
        getAccessibilityResults: () => Promise<Array<{ [key: string]: any; }>>
+        performScan: () => Promise<unknown>


change type

07souravkunda · 2024-02-28T14:25:47Z

packages/wdio-browserstack-service/src/accessibility-handler.ts

+                                  (
+                                      !command.name.includes('execute') ||
+                                      !AccessibilityHandler.isBrowserstackScript(args.length ? args[0] : null)
+                                  )


07souravkunda · 2024-02-28T14:28:19Z

packages/wdio-browserstack-service/src/accessibility-handler.ts

        const isPageOpened = await this.checkIfPageOpened(this._browser, testIdentifier, shouldScanTest)

+        if (this._sessionId) {
+            /* For case with multiple tests under onw browser, before hook of 2nd test should change this map value */


07souravkunda · 2024-02-28T14:29:53Z

packages/wdio-browserstack-service/src/accessibility-handler.ts

        const isPageOpened = await this.checkIfPageOpened(this._browser, uniqueId, shouldScanScenario)

+        if (this._sessionId) {
+            /* For case with multiple tests under onw browser, before hook of 2nd test should change this map value */


…owserstack-accessibility-stability-changes" This reverts commit 13c0588, reversing changes made to 5bf738a.

rev-doshi and others added 30 commits February 13, 2024 10:51

changes for accessibility automation inbrowserstack service

2ad546b

(webdriverio): merge isDisplayed and isDisplayedWithinViewport (webdr…

cfbd498

…iverio#11857) * (webdriverio): merge isDisplayed and isDisplayedWithinViewport * allow to specify withinViewport check in waitForDisplayed

(internal): update some dependencies that couldn't be updated due to …

355e314

…support for Node.js v16 closes webdriverio#11938 fixes webdriverio#11858

(webdriverio): make puppeteer a peer dependency

220ad32

fix type issues fix unit tests

update all dependencies

cbbdc9e

update dependabot and stop update for v7

57501e2

remove tsconfig-path as dev dependency

806b3d8

no update for Vite in v8 anymore

e42729a

no update for puppeteer-core in v8 anymore

7631b53

move to change-case as param-case is deprecated

44add99

don't update read-pkg-up due to missing Node.js v16 support

881bd6a

don't update formdata-node due to missing Node.js v16 support

9ed28d2

fix change-case update

3ce2af0

(feat): migrate to pnpm - fixes webdriverio#12299

a97d1b1

(fix): set moduleResolution to Node16 where possible

f52a4be

(fix): add missing esbuild dev dep

f206fdf

(fix): smoke tests

00ad717

(fix): component tests

a0441f1

(fix): workflow for windows and mac

2f25468

(fix): remove obsolete sponsor image

ed96378

Bump @puppeteer/browsers from 1.9.1 to 2.0.1 (webdriverio#12303)

2c61495

Updating capabilities for Lamdatest & Browserstack (webdriverio#12302)

307156b

* Updating capabilities for Lamdatest & Browserstack * fix bootstrap & component test

(internal): enable ci tests for v8

7e52f7b

amaanbs and others added 3 commits February 20, 2024 05:18

A11y Wdio stability init

5bf738a

docs: Updated Contributing guide to mention PNPM instead of NPM (webd…

e44d355

…riverio#12318) * docs: Updated Contributing guide to mention PNPM instead of NPM * docs: Corrected pnpm commands

Merge branch main of github.com:rev-doshi/webdriverio into browsersta…

13c0588

…ck-accessibility-stability-changes

07souravkunda suggested changes Feb 28, 2024

View reviewed changes

Revert "Merge branch main of github.com:rev-doshi/webdriverio into br…

317e141

…owserstack-accessibility-stability-changes" This reverts commit 13c0588, reversing changes made to 5bf738a.

amaanbs changed the base branch from main to v8 March 1, 2024 00:00

amaanbs changed the base branch from v8 to main March 1, 2024 00:05

amaanbs changed the base branch from main to v8 March 1, 2024 00:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

changes for accessibility automation inbrowserstack service #1

changes for accessibility automation inbrowserstack service #1

Uh oh!

rev-doshi commented Feb 13, 2024

Uh oh!

07souravkunda Feb 28, 2024

Uh oh!

07souravkunda Feb 28, 2024

Uh oh!

07souravkunda Feb 28, 2024

Uh oh!

07souravkunda Feb 28, 2024

Uh oh!

07souravkunda Feb 28, 2024

Uh oh!

07souravkunda Feb 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

changes for accessibility automation inbrowserstack service #1

Are you sure you want to change the base?

changes for accessibility automation inbrowserstack service #1

Uh oh!

Conversation

rev-doshi commented Feb 13, 2024

Proposed changes

Types of changes

Checklist

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

07souravkunda Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

07souravkunda Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

07souravkunda Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

07souravkunda Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

07souravkunda Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

07souravkunda Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants