Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Contact URI that have parameter "ob", the request URI will set to first Route.
This is incorrect, and Kamaillio will reject it.
From RFC 5626:
So it only take effect on the destination of message, not the message itself.
Since there are mixd use between Request-URI and destination, I have refactor the make_ack, and add strict route support.
Now make_ack take both initial INVITE and response, for non-200 ACK it use message from the invite(except TO-tag), and use information from the Response for 200 ACK (request URI and Route )
Complement with https://datatracker.ietf.org/doc/html/rfc3261#section-12.2.1.1: