feat: migrate proxy sidecar injection and add Deployment proxy reconc…#5
Open
Vaishnav88sk wants to merge 3 commits into
Open
feat: migrate proxy sidecar injection and add Deployment proxy reconc…#5Vaishnav88sk wants to merge 3 commits into
Vaishnav88sk wants to merge 3 commits into
Conversation
…iler Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Vaishnav88sk
force-pushed
the
feature/proxy-sidecar-injection
branch
from
7275ca9 to
b7cac9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the Kubernetes admission controller logic for injecting the Reshapr proxy sidecar from the
reshaprrepository toreshapr-controllers, fulfilling the architectural requirements outlined by maintainers.Fixes #4
I would like to hear your thoughts on this. I have made chnages according my understandings. If any chnages, please let me know!