Fix: event setup to initialize with an empty array#6
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies how EventsExtension::bindEventProperties() wires Nette-style onXxx event properties during DI container compilation.
Changes:
- Adjusts the DI setup expression for autowired event properties from assigning to the property to appending to it (
$onXxx→$onXxx[]).
Comments suppressed due to low confidence (1)
src/Events/DI/EventsExtension.php:415
- Changing the setup target from
$onXto$onX[]no longer replaces the Nette event property with aKdyby\Events\Eventinstance; it appends the createdEventinto the existing array/ArrayAccess instead. This breaks the documented/covered behavior where$service->onSomethingis expected to be anEvent(seetests/KdybyTests/Events/ExtensionTest.phptassertions like$app->onStartup instanceof Event). It also changes listener ordering semantics and can introduce recursion/ordering issues.
If the goal is to avoid accessing an uninitialized typed property when passing defaults, keep the assignment to $onX and make the defaults argument safe via isset($service->onX) ? $service->onX : [] (or an equivalent approach that doesn’t read an uninitialized property).
$def->addSetup('$' . $name . '[]', [
new Statement($this->prefix('@manager') . '::createEvent', [
[$class->getName(), $name],
new PhpLiteral('$service->' . $name),
NULL,
$dispatchAnnotation ?? $this->loadedConfig['globalDispatchFirst'],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.