fix: coerce numeric fallback values in contact-properties update command

[bukinoshita]

The update command never looks up the property's declared type and never coerces --fallback-value. Commander supplies option values as strings, so --fallback-value 42 becomes '42' and is forwarded unchanged.

const fallbackValue = opts.clearFallbackValue ? null : opts.fallbackValue;

await runWrite(
  {
    sdkCall: (resend) =>
      resend.contactProperties.update({
        id,
        ...(fallbackValue !== undefined && { fallbackValue }),
      }),
  },
  globalOpts,
);

By contrast, the create command explicitly converts numeric fallbacks to numbers and rejects non-numeric input for type === 'number':

let fallbackValue: string | number | undefined;
if (opts.fallbackValue !== undefined) {
  if (type === 'number') {
    const parsed = parseFloat(opts.fallbackValue);
    if (Number.isNaN(parsed)) {
      outputError({
        message: '--fallback-value must be a valid number for number-type properties.',
        code: 'invalid_fallback_value',
      });
    }
    fallbackValue = parsed;
  } else {
    fallbackValue = opts.fallbackValue;
  }
}

The test suite also encodes this inconsistency:

• create test expects numeric coercion to 42
• update test only validates string passthrough and has no numeric case

await createContactPropertyCommand.parseAsync(
  ['--key', 'score', '--type', 'number', '--fallback-value', '42'],
  { from: 'user' },
);
expect(args.fallbackValue).toBe(42);

await updateContactPropertyCommand.parseAsync(
  ['b4a3c2d1-6e5f-8a7b-0c9d-2e1f4a3b6c5d', '--fallback-value', 'Acme Corp'],
  { from: 'user' },
);
expect(args.fallbackValue).toBe('Acme Corp');

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/commands/contact-properties/update.ts">

<violation number="1" location="src/commands/contact-properties/update.ts:93">
P2: Help metadata error code list is outdated and omits newly introduced runtime errors (`fetch_error`, `invalid_fallback_value`).</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[felipefreitag]

Just the issue Cubic pointed out