Introduce opentelemetry in rewatch and setup new test infrastructure#8241
Draft
nojaf wants to merge 16 commits intorescript-lang:masterfrom
Draft
Introduce opentelemetry in rewatch and setup new test infrastructure#8241nojaf wants to merge 16 commits intorescript-lang:masterfrom
nojaf wants to merge 16 commits intorescript-lang:masterfrom
Conversation
writes Watcher skips events where file content is unchanged; test helper uses temp file + rename to avoid truncation races.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of #8231.
I wish to introduce open telemetry in Rewatch and migrate the bash tests to a new test suite.
The new tests would look like:
Where we capture all telemetry traces produced inside
runRewatchTestand extract a deterministic snapshot of this:With this telemetry we can easily update snapshots and assert all still works as expected.
By using Vitest we also have a proper test runner, so can run individual tests.
All tests also run in a sandbox folder in the
/tmp, we they cannot interfere with each other.And they can run in parallel.
The goal is too replace and remove the existing bash tests.