Fix algolia returing a null value on lvl1 on certain pages #1175
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
approved these changes
Jan 28, 2026
Collaborator
aspeddro
left a comment
aspeddro
left a comment
There was a problem hiding this comment.
Thx @lungarella-raffaele !!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
While working with the project, I discovered that Algolia sends unexpected null values when searching for certain strings. The culprits appear to be "publish" and "libraries", which both reference
markdown-pages/docs/manual/libraries.mdx. When searching for a substring within this page, DocSearch crashes because it attempts to call replace on an lvl1 value that is null.During my investigation, I noticed that Algolia was sending content that doesn't exist on the same page, maybe some misalignment? So perhaps that's the reason for this bug and my fix may be redundant. However, if Algolia can send null values, it's breaking the specified contract and we shouldn't trust their data implicitly.
Does my fix makes sense? Or there is a better way?