Skip to content

Fix Accessibility Violations - Add Accessible Names to Interactive El… #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhammerschmidt merged 3 commits into from
Jan 22, 2026
Merged

Fix Accessibility Violations - Add Accessible Names to Interactive El… #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6154a1
Fix Accessibility Violations - Add Accessible Names to Interactive El…
huangkevin-apr Jan 22, 2026
c9cfa63
Refine accessibility fix
huangkevin-apr Jan 22, 2026
1a4764c
use camelCased for fixes
huangkevin-apr Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/Navigation.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ let make = (~fixed=true, ~isOverlayOpen: bool, ~setOverlayOpen: (bool => bool) =
to="/"
className="block hover:cursor-pointer w-full h-full flex justify-center items-center font-bold"
>
<img src="/brand/rescript-brandmark.svg" className="lg:hidden" />
<img src="/brand/rescript-logo.svg" className="hidden lg:block" />
<img src="/brand/rescript-brandmark.svg" className="lg:hidden" alt="ReScript Home" />
<img src="/brand/rescript-logo.svg" className="hidden lg:block" alt="ReScript Home" />
</Link.String>
</div>

Expand Down Expand Up @@ -177,16 +177,16 @@ let make = (~fixed=true, ~isOverlayOpen: bool, ~setOverlayOpen: (bool => bool) =
<div className="md:flex flex items-center text-gray-60">
<Search />
<div className="hidden md:flex items-center ml-5">
<a href=Constants.githubHref rel="noopener noreferrer" className={"mr-5 " ++ link}>
<a href=Constants.githubHref rel="noopener noreferrer" className={"mr-5 " ++ link} ariaLabel="GitHub">
<Icon.GitHub className="w-6 h-6 opacity-50 hover:opacity-100" />
</a>
<a href=Constants.xHref rel="noopener noreferrer" className={"mr-5 " ++ link}>
<a href=Constants.xHref rel="noopener noreferrer" className={"mr-5 " ++ link} ariaLabel="X (formerly Twitter)">
<Icon.X className="w-6 h-6 opacity-50 hover:opacity-100" />
</a>
<a href=Constants.blueSkyHref rel="noopener noreferrer" className={"mr-5 " ++ link}>
<a href=Constants.blueSkyHref rel="noopener noreferrer" className={"mr-5 " ++ link} ariaLabel="Bluesky">
<Icon.Bluesky className="w-6 h-6 opacity-50 hover:opacity-100" />
</a>
<a href=Constants.discourseHref rel="noopener noreferrer" className=link>
<a href=Constants.discourseHref rel="noopener noreferrer" className=link ariaLabel="Forum">
<Icon.Discourse className="w-6 h-6 opacity-50 hover:opacity-100" />
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Search.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ let make = () => {
}, [setState])

<>
<button onClick type_="button" className="text-gray-60 hover:text-fire-50 p-2">
<button onClick type_="button" className="text-gray-60 hover:text-fire-50 p-2" ariaLabel="Search">
<Icon.MagnifierGlass className="fill-current" />
</button>
{switch state {
Expand Down