Skip to content

refactor: undo monorepo#260

Open
jderochervlk wants to merge 10 commits intomainfrom
unmonorepo-webapi-redo
Open

refactor: undo monorepo#260
jderochervlk wants to merge 10 commits intomainfrom
unmonorepo-webapi-redo

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread docs/content/docs/index.mdx Outdated
Comment thread docs/content/docs/index.mdx Outdated
Comment thread docs/content/docs/philosophy.mdx Outdated
Comment thread docs/content/docs/philosophy.mdx Outdated
Comment thread docs/content/docs/philosophy.mdx Outdated
@fhammerschmidt
Copy link
Copy Markdown
Member

oh no! why?

@jderochervlk jderochervlk requested review from brnrdog and tsnobip April 23, 2026 11:45
@jderochervlk
Copy link
Copy Markdown
Collaborator Author

oh no! why?

We won't need to ship separate npm packages because of this: rescript-lang/rescript#8379

Copy link
Copy Markdown
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undoing the monorepo would allow to have have a structure quite similar to what it was before, just with extracted "base" types. Now we should really think about how we want to call these base types (Base.DOM, BaseDOM, other?). I'm wondering if we couldn't come up with an even smarter structure with the features.

Edit: I'm quite excited to see we're close to finally reach the alpha haha

Comment thread src/DOM/DOM.res Outdated
Comment thread docs/superpowers/specs/2026-04-22-unmonorepo-webapi-design.md
Comment thread docs/superpowers/specs/2026-04-22-unmonorepo-webapi-design.md
@jderochervlk
Copy link
Copy Markdown
Collaborator Author

Undoing the monorepo would allow to have have a structure quite similar to what it was before, just with extracted "base" types. Now we should really think about how we want to call these base types (Base.DOM, BaseDOM, other?). I'm wondering if we couldn't come up with an even smarter structure with the features.

Edit: I'm quite excited to see we're close to finally reach the alpha haha

I think using DOM as a module would be good for things like element, document, etc...

@jderochervlk
Copy link
Copy Markdown
Collaborator Author

@codex

@jderochervlk jderochervlk requested a review from tsnobip May 5, 2026 18:13
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fde4ee8d4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants