Support creating projects in current directory#128
Support creating projects in current directory#128fhammerschmidt wants to merge 1 commit intorescript-lang:masterfrom
Conversation
commit: |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb4dd7a5a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "readme.md", | ||
| ] | ||
|
|
||
| let isCurrentDirectoryProject = projectName => projectName === currentDirectoryArgument |
There was a problem hiding this comment.
The current-directory detection only matches the exact string ".", so a common equivalent input like create-rescript-app ./ --template vite is treated as a regular project name and then rejected by the package-name regex. This makes the new current-directory flow fail for a valid path form users often pass from shell completion/scripts; normalizing the argument (e.g., resolving ./ to .) before validation would avoid this regression.
Useful? React with 👍 / 👎.
1 participant
Fixes #53