Skip to content

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 5, 2025

Just some minor, mostly non-functional test cleanup, wrapping up things I had lying around.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Web viewer built successfully.

Result Commit Link Manifest
4911244 https://rerun.io/viewer/pr/12124 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf requested a review from Copilot December 7, 2025 09:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs minor, mostly non-functional cleanup of tests in the TransformResolutionCache module. The changes improve code readability and maintainability by reorganizing imports, refactoring repetitive test assertions into loops, and simplifying method calls.

  • Simplified imports by removing unused items and directly importing commonly-used types
  • Refactored repetitive test assertions into loop-based structures for better maintainability
  • Cleaned up method call formatting by removing unnecessary line breaks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

let num_bytes_after_gc = cache.total_size_bytes();
assert!(
num_bytes_after_gc < num_bytes_before_gc,
"Expected cache size to decrease after GC (before/after: {num_bytes_before_gc} bytes)"
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message incorrectly refers to 'before/after' but only includes the 'before' value. Update the message to include both values: \"Expected cache size to decrease after GC (before: {num_bytes_before_gc} bytes, after: {num_bytes_after_gc} bytes)\"

Suggested change
"Expected cache size to decrease after GC (before/after: {num_bytes_before_gc} bytes)"
"Expected cache size to decrease after GC (before: {num_bytes_before_gc} bytes, after: {num_bytes_after_gc} bytes)"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants