-
Notifications
You must be signed in to change notification settings - Fork 592
TransformResolutionCache test cleanup
#12124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs minor, mostly non-functional cleanup of tests in the TransformResolutionCache module. The changes improve code readability and maintainability by reorganizing imports, refactoring repetitive test assertions into loops, and simplifying method calls.
- Simplified imports by removing unused items and directly importing commonly-used types
- Refactored repetitive test assertions into loop-based structures for better maintainability
- Cleaned up method call formatting by removing unnecessary line breaks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let num_bytes_after_gc = cache.total_size_bytes(); | ||
| assert!( | ||
| num_bytes_after_gc < num_bytes_before_gc, | ||
| "Expected cache size to decrease after GC (before/after: {num_bytes_before_gc} bytes)" |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message incorrectly refers to 'before/after' but only includes the 'before' value. Update the message to include both values: \"Expected cache size to decrease after GC (before: {num_bytes_before_gc} bytes, after: {num_bytes_after_gc} bytes)\"
| "Expected cache size to decrease after GC (before/after: {num_bytes_before_gc} bytes)" | |
| "Expected cache size to decrease after GC (before: {num_bytes_before_gc} bytes, after: {num_bytes_after_gc} bytes)" |
Just some minor, mostly non-functional test cleanup, wrapping up things I had lying around.